Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

198 Include user's card labels when generating the report #584

Merged
merged 19 commits into from
Oct 13, 2023
Merged

198 Include user's card labels when generating the report #584

merged 19 commits into from
Oct 13, 2023

Conversation

kartikeyakirar
Copy link
Contributor

this PR fixes #583

this is follow-up after insightsengineering/teal.reporter#219

@kartikeyakirar kartikeyakirar marked this pull request as draft October 4, 2023 08:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    829     829  0.00%    72-1025
R/tm_a_regression.R             716     716  0.00%    92-891
R/tm_data_table.R               171     171  0.00%    58-281
R/tm_file_viewer.R              172     172  0.00%    39-241
R/tm_front_page.R               127     116  8.66%    63-205
R/tm_g_association.R            333     333  0.00%    89-480
R/tm_g_bivariate.R              655     495  24.43%   124-705, 753, 759, 763, 874, 891, 909, 929-951
R/tm_g_distribution.R          1028    1028  0.00%    110-1260
R/tm_g_response.R               349     349  0.00%    85-498
R/tm_g_scatterplot.R            719     719  0.00%    160-970
R/tm_g_scatterplotmatrix.R      280     261  6.79%    78-375, 429, 443
R/tm_missing_data.R            1044    1044  0.00%    58-1239
R/tm_outliers.R                 976     976  0.00%    76-1181
R/tm_t_crosstable.R             254     254  0.00%    81-373
R/tm_variable_browser.R         834     829  0.60%    61-1326
R/utils.R                       122     122  0.00%    74-351
R/zzz.R                           1       1  0.00%    2
TOTAL                          8610    8415  2.26%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/tm_a_pca.R                     +1      +1  +100.00%
R/tm_a_regression.R              +2      +2  +100.00%
R/tm_g_association.R             +2      +2  +100.00%
R/tm_g_bivariate.R               +2      +2  -0.07%
R/tm_g_distribution.R            +2      +2  +100.00%
R/tm_g_response.R                +2      +2  +100.00%
R/tm_g_scatterplot.R             +2      +2  +100.00%
R/tm_g_scatterplotmatrix.R       +2      +2  -0.05%
R/tm_missing_data.R              +5      +5  +100.00%
R/tm_outliers.R                  +2      +2  +100.00%
R/tm_t_crosstable.R              +2      +2  +100.00%
R/tm_variable_browser.R          +2      +2  -0.00%
TOTAL                           +26     +26  -0.01%

Results for commit: 73d5539

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@kartikeyakirar kartikeyakirar mentioned this pull request Oct 4, 2023
Merged
@kartikeyakirar kartikeyakirar marked this pull request as ready for review October 5, 2023 10:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023 •
edited
Loading

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0 ❌
49 runs  49 ✔️ 0 💤 0 ❌

Results for commit 73d5539.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-requested a review October 6, 2023 13:36
@m7pr
Copy link
Contributor

m7pr commented Oct 6, 2023

Hey @kartikeyakirar one general comment to all PRs.
Can you move card_template function to teal.reporter? So that we do not have 4 the same functions in here, insightsengineering/teal.modules.hermes#336 insightsengineering/teal.goshawk#241 and insightsengineering/teal.goshawk#241

Can you also apply the same in tmc? insightsengineering/teal.modules.clinical#835

This was referenced Oct 6, 2023
Merged
Merged
m7pr
m7pr requested changes Oct 12, 2023
View reviewed changes
.lintr Show resolved Hide resolved
@kartikeyakirar kartikeyakirar mentioned this pull request Oct 12, 2023
Merged
@m7pr
Copy link
Contributor

m7pr commented Oct 13, 2023

Hey @kartikeyakirar looks like this staged deps cyclic error does not appear on this PR anymore. You are good to merge

kartikeyakirar added a commit to insightsengineering/teal that referenced this pull request Oct 13, 2023
@kartikeyakirar @github-actions
@m7pr @dependabot-preview
198 extension to Include user's card labels when generating the report (
57fdce9 
#933)

this PR is extension to
insightsengineering/teal.reporter#198

Here I have added card_template() function that generates a report card
with a title,
an optional description, and the option to append the filter state list.
and is been used in
insightsengineering/teal.modules.general#584
insightsengineering/teal.modules.clinical#835
insightsengineering/teal.modules.hermes#336
insightsengineering/teal.osprey#229
insightsengineering/teal.goshawk#241

ref issues and discussion:
insightsengineering/teal.reporter#226

---------

Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@kartikeyakirar kartikeyakirar merged commit b840906 into main Oct 13, 2023
20 checks passed
@kartikeyakirar kartikeyakirar deleted the 198_card_labels@main branch October 13, 2023 09:45
@donyunardi donyunardi mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m7pr m7pr m7pr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Rewrite modules so they include user's card labels when generating the report
2 participants
@kartikeyakirar @m7pr